Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove duplicated dependency versions #2143

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jjohannes
Copy link
Contributor

Description:

Some versions for dependency groups – such as all io.grpc:* dependencies – were defined multiple times. This let to multiple Dependabot PRs for the same versions, leading to inconsistencies between merging of the several PRs.

Each repeated version is now only defined once in a val in the hiero-dependency-versions/build.gradle.kts file. This notation is supported by Dependabot.

This also addresses the point Resolve duplication in constraints publishing (right now there is some duplication) of issue #1794.

Related issue(s):

#1794

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (manually)

Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjohannes jjohannes merged commit bbfabe3 into main Dec 16, 2024
7 checks passed
@jjohannes jjohannes deleted the 1794-deduplicat-versions branch December 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants